Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep between initial write and update to prevent intermittent test failures. #639

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

LiranCohen
Copy link
Member

Was experiencing testing intermittent test failures triggering a 409 conflict error.

Copy link

codesandbox bot commented Dec 3, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c0fdb5) 98.80% compared to head (172112a) 98.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          71       71           
  Lines        9004     9004           
  Branches     1365     1365           
=======================================
  Hits         8896     8896           
  Misses        100      100           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@LiranCohen LiranCohen merged commit 3bb47ca into main Dec 10, 2023
4 checks passed
@LiranCohen LiranCohen deleted the lirancohen/sleep-between-create-and-update-test branch January 10, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants